Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OU-ADD] account: Migration to 16.0 #462

Merged
merged 3 commits into from
Jul 25, 2023
Merged

[OU-ADD] account: Migration to 16.0 #462

merged 3 commits into from
Jul 25, 2023

Conversation

duong77476-viindoo
Copy link

@duong77476-viindoo duong77476-viindoo commented Jul 15, 2023 •
edited
Loading

  • account.accouunt: Account type in account template and account
  • account.move: auto_post
  • account.move.line: Delete sql_contraints, display_type
  • account.move.line: Dynamic analytic_distribution fill yeahhh
  • account.journal: Delete sql_contraints
  • account.payment: Add field amount_company_currency_signed
  • account.bank.statement: internal_index, first_line_index, is_complete

https://youtu.be/f1vUk11DpiU (credit : @ngochung207 )

@duong77476-viindoo duong77476-viindoo mentioned this pull request Jul 15, 2023
Closed
@ngochung207
Copy link

@duong77476 : add code: openupgrade.rename_xmlids(env, _xmlids_renames) in pre-migration

@duong77476-viindoo
Copy link
Author

Yes sir

@duong77476-viindoo duong77476-viindoo force-pushed the v16_mig_account branch 2 times, most recently from 8571e8c to fc51fe8 Compare July 17, 2023 10:35
This was referenced Jul 19, 2023
Merged
Merged
@duong77476-viindoo duong77476-viindoo force-pushed the v16_mig_account branch 7 times, most recently from 81b8a9b to 90030e0 Compare July 21, 2023 11:26
@nguyenvietlam0640
Copy link

chỗ này khi migration anh xóa giúp em xmlid action_bank_statement_form_bank nữa nhé, ở pre hay post đều được.
Vấn đề:
nếu migrate riêng account thì không sao, nhưng khi migrate viin_account_reconciliation sẽ raise ra lỗi như sau:
image

Lý do:
Ở bản odoo 15 vẫn còn action_bank_statement_form_bank nhưng trên odoo16 thì không còn nữa. Nếu không xoá xmlid này đi thì ORM sẽ tự xử lí sau cùng. Nhưng trên bản 16 module viin_account_reconciliation chúng ta lại thêm 1 xmlid mới có tên là action_bank_statement_view_form có cùng tính chất với action trên thành ra cũ chưa xóa mà mới đã thêm vào nên dính unique constraint.

@duong77476-viindoo
Copy link
Author

action_bank_statement_form_bank

Chưa chắc chuẩn mà xử ở account cũng ko chuẩn bằng xử ở viin_account_reconciliation, a xử ở đây rồi https://github.com/Viindoo/odoo-openupgrade-tvtmaaddons/pull/428

royle-vietnam
royle-vietnam reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@royle-vietnam royle-vietnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sửa hết comment là có thể merge được

ngochung207 and others added 2 commits July 24, 2023 18:24
@ngochung207 @duong77476-viindoo
[OU-ADD] accont: Migration to 16
ed17b6b 
account: more analysis on xml
account.accouunt: Account type in account template and account
 - account.move: auto_post
 - account.move.line: Delete sql_contraints, display_type
 - account.move.line: Dynamic analytic_distribution fill yeahhh
 - account.journal: Delete sql_contraints
 - account.payment: Add field amount_company_currency_signed
 - account.bank.statement: internal_index, first_line_index, is_complete
@duong77476-viindoo
[OU-IMP] account: simplify analytic_distribution generate
47c5659
@duong77476-viindoo duong77476-viindoo force-pushed the v16_mig_account branch 6 times, most recently from 5822e37 to 6b8377d Compare July 24, 2023 15:34
@duong77476-viindoo
[OU-IMP] account: simplify some fast fill stuff and remove unneeded
fea6933 
method

-display_type improvement
-remove bank statement fastfill
-add account_reconcile_model_line analytic_distribution generate
-improve analytic_distribution_model generation from analytic default
@royle-vietnam royle-vietnam merged commit 9f86440 into Viindoo:16.0 Jul 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royle-vietnam royle-vietnam royle-vietnam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duong77476-viindoo @ngochung207 @nguyenvietlam0640 @royle-vietnam